[FIX] Fix filter_events uri parameter order#13
Open
lrapp-adan wants to merge 1 commit intodfir-iris:masterfrom
Open
[FIX] Fix filter_events uri parameter order#13lrapp-adan wants to merge 1 commit intodfir-iris:masterfrom
lrapp-adan wants to merge 1 commit intodfir-iris:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the
filter_eventsfunction callspi_get(return self._s.pi_get(f'case/timeline/advanced-filter?q={filter_uri}&', cid=cid)) leads to theqparameter being placed before thecidparameter.One would not expect this to be a problem, but it is, as the API seems to expect the URI-parameters the other way around. This leads to the strange behavior of the API returning data from some other case id. (The last successfully accessed one? Maybe a caching problem / bug in iris-web? Unfortunately, I was not able to identify the root cause yet.)
However, this PR fixes the URI parameter order for the
filter_eventsfunction to make it work for now.